[CL][Swap Router Module]: improve TestMultihopSwapExactAmountIn and TestMultihopSwapExactAmountOut

[p0mvn]

Background

Desired test cases are listed here for TestMultihopSwapExactAmountIn:

osmosis/x/swaprouter/router_test.go

Lines 131 to 140 in d76deee

	// TODO:
	// tests for concentrated liquidity
	// test for multi-hop
	// test for multi hop (osmo routes) -> reduces fee, add an assertion
	// change values in and out to be different with each swap module type
	// create more precise assertions on what the results are
	// edge cases:
	// * invalid route length
	// * pool does not exist
	// * swap errors

and here for TestMultihopSwapExactAmountOut:

osmosis/x/swaprouter/router_test.go

Lines 131 to 140 in d76deee

	// TODO:
	// tests for concentrated liquidity
	// test for multi-hop
	// test for multi hop (osmo routes) -> reduces fee, add an assertion
	// change values in and out to be different with each swap module type
	// create more precise assertions on what the results are
	// edge cases:
	// * invalid route length
	// * pool does not exist
	// * swap errors

Acceptance Criteria

• all proposed test cases are covered
• new test cases are added if applicable

[hieuvubk]

Hello anyone working on this issue? I would like to work with it

[p0mvn]

Hi @hieuvubk . I'm afraid it’s currently blocked on: #3170

I’m planning to finalize that PR soon. Will lyk once this issue is unblocked. Thanks

[hieuvubk]

Yes thank u

[p0mvn]

This is now blocked on #3238 since we need proper routing to work first

[p0mvn]

Some progress towards this has been done in: #3490

However, there is still more to test. swaprouter module is currently on code-freeze until we finish merge to main

[p0mvn]

We still need to add a test with a concentrated liquidity pool, upon merging the module to main