Skip to content

Commit

Permalink
link issues
Browse files Browse the repository at this point in the history
  • Loading branch information
p0mvn committed Oct 24, 2022
1 parent 1f9680c commit d76deee
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
7 changes: 4 additions & 3 deletions x/gamm/keeper/swap.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ import (
// tokenOutMinAmount must be returned in the resulting asset returning an error
// upon failure. Upon success, the resulting tokens swapped for are returned. A
// swap fee is applied determined by the pool's parameters.
// TODO: decide the future of this method. Should we remove it?
// TODO: remove this method:
// https://github.com/osmosis-labs/osmosis/issues/3129
func (k Keeper) SwapExactAmountInDefaultSwapFee(
ctx sdk.Context,
sender sdk.AccAddress,
Expand All @@ -37,8 +38,8 @@ func (k Keeper) SwapExactAmountInDefaultSwapFee(
// as input to a pool, using the provided swapFee. This is intended to allow
// different swap fees as determined by multi-hops, or when recovering from
// chain liveness failures.
// TODO: investigate if we can only export this method for the swap-router module
// to mitigate the security risk from swapFee being taken in.
// TODO: investigate if swapFee can be unexported
// https://github.com/osmosis-labs/osmosis/issues/3130
func (k Keeper) SwapExactAmountIn(
ctx sdk.Context,
sender sdk.AccAddress,
Expand Down
2 changes: 2 additions & 0 deletions x/swaprouter/router.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ func (k Keeper) RouteExactAmountIn(
tokenIn sdk.Coin,
tokenOutMinAmount sdk.Int) (tokenOutAmount sdk.Int, err error) {
// TODO: fix this once proper pool id routing exists
// https: //github.com/osmosis-labs/osmosis/issues/3097
isGamm := true

swapModule := k.withSwapModule(isGamm)
Expand Down Expand Up @@ -62,6 +63,7 @@ func (k Keeper) RouteExactAmountOut(ctx sdk.Context,
tokenInMaxAmount sdk.Int,
tokenOut sdk.Coin) (tokenInAmount sdk.Int, err error) {
// TODO: fix this once proper pool id routing exists
// https://github.com/osmosis-labs/osmosis/issues/3097
isGamm := true

swapModule := k.withSwapModule(isGamm)
Expand Down

0 comments on commit d76deee

Please sign in to comment.