Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CL][Misc]: rename Mint and Burn abstractions #3108

Closed
p0mvn opened this issue Oct 24, 2022 · 2 comments
Closed

[CL][Misc]: rename Mint and Burn abstractions #3108

p0mvn opened this issue Oct 24, 2022 · 2 comments
Assignees
@mattverse
Labels
C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:task ⚙️ A task belongs to a story
Milestone
CL4: Precise Loga...

Comments

@p0mvn
Copy link
Member

p0mvn commented Oct 24, 2022

Background

For adding liquidity, we went with the "Mint" abstraction. For removing, it is likely to end up being "Burn".

Suggested Design

I would like to propose renaming Mint and Burn abstractions to the following options:

  • AddLiquidity and RemoveLiquidity
  • CreatePosition and WithdrawPosition

The reason is that we already use mint / burn names in x/mint , x/tokenfactory and x/bank so I think it would make it easier to be precise what exactly we are talking about.

Leaving the final choice of the name up to the person working on this.

Acceptance Criteria

  • names changed
  • ensure tests are updated to reflect the name change as well
@p0mvn p0mvn added C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board labels Oct 24, 2022
@p0mvn p0mvn added the T:task ⚙️ A task belongs to a story label Oct 24, 2022
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Oct 24, 2022
@p0mvn p0mvn mentioned this issue Oct 24, 2022
Closed
@mattverse mattverse changed the title [CL][Liquidity Provision]: rename Mint and Burn abstractions [CL][Misc]: rename Mint and Burn abstractions Oct 24, 2022
@mattverse mattverse self-assigned this Oct 25, 2022
@mattverse
Copy link
Member

We don't have burning methods for now, burning could be addressed in the future PRs when the feature is introduced

@mattverse
Copy link
Member

Done in #3139

Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattverse mattverse

Labels
C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:task ⚙️ A task belongs to a story
Projects
Osmosis Chain Development
Archived in project
Milestone
CL4: Precise Logarithm, Improved Wiri...
Development

No branches or pull requests
2 participants
@p0mvn @mattverse