Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story][CL]: Concentrated Liquidity Module #3041

Closed
Tracked by #3014
p0mvn opened this issue Oct 18, 2022 · 1 comment
Closed
Tracked by #3014

[Story][CL]: Concentrated Liquidity Module #3041

p0mvn opened this issue Oct 18, 2022 · 1 comment
Labels
C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:story A story belongs to an epic

Comments

@p0mvn
Copy link
Member

p0mvn commented Oct 18, 2022

Background

As an engineer, I would like the concentrated liquidity logic to exist in its own module so that I can easily reason about the concentrated liquidity abstraction that is different from the existing pools.

Since concentrated liquidity architecture diverges from the existing amm logic, we would like to encapsulate the new implementation in its own module.

Suggested Design

Specifically, we would like to implement the following keeper methods:

  • CreatePool
  • JoinPool
  • ExitPool
  • SwapExactAmountIn
  • SwapExactAmountOut

This new module will not have any messages or the message server. Instead, we will implement separate modules that will call into the keeper methods of the concentrated-liquidity module.

Tasks

Acceptance Criteria

  • new module is implemented
  • follows twap folder structure
  • no message server
  • all keeper methods implemented
  • utilizes the concentrated pool model
  • test coverage is maximized
@p0mvn p0mvn added the T:story A story belongs to an epic label Oct 18, 2022
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Oct 18, 2022
@p0mvn p0mvn modified the milestone: CL 2: Module Wiring Oct 18, 2022
@p0mvn p0mvn added the F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board label Oct 19, 2022
@p0mvn
Copy link
Member Author

p0mvn commented Jan 12, 2023

The core of the new concentrated liquidity module is now implemented so we consider this story as complete

@p0mvn p0mvn closed this as completed Jan 12, 2023
@github-project-automation github-project-automation bot moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:story A story belongs to an epic
Projects
Archived in project
Development

No branches or pull requests

1 participant