Skip to content

Commit

Permalink
added note for pfm bug (#5885)
Browse files Browse the repository at this point in the history
  • Loading branch information
nicolaslara authored Jul 25, 2023
1 parent 4aeaaa5 commit 875b929
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion x/ibc-hooks/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ The cosmwasm `MsgExecuteContract` is defined [here](https://github.com/CosmWasm/

```go
type MsgExecuteContract struct {
// Sender is the that actor that signed the messages
// Sender is the actor that committed the message in the sender chain
Sender string
// Contract is the address of the smart contract
Contract string
Expand All @@ -39,6 +39,8 @@ This is done by setting the sender to `Bech32(Hash("ibc-wasm-hook-intermediary"
* Msg: This field should be directly obtained from the ICS-20 packet metadata.
* Funds: This field is set to the amount of funds being sent over in the ICS 20 packet. One detail is that the denom in the packet is the counterparty chains representation of the denom, so we have to translate it to Osmosis' representation.

> **_WARNING:_** Due to a [bug](https://twitter.com/SCVSecurity/status/1682329758020022272) in the packet forward middleware, we cannot trust the sender from chains that use PFM. Until that is fixed, we recommend chains to not trust the sender on contracts executed via IBC hooks.
So our constructed cosmwasm message that we execute will look like:

```go
Expand Down

0 comments on commit 875b929

Please sign in to comment.