fix ListPoolsByDenom method (#7341)

* fix `ListPoolsByDenom` method * a test * update changelog
osmosis-labs · Feb 17, 2024 · 7d734f6 · 7d734f6
1 parent 1606b76
commit 7d734f6
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -62,6 +62,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Bug Fixes
 
 * [#7360](https://github.com/osmosis-labs/osmosis/pull/7360) fix: use gov type for SetScalingFactorController
+* [#7341](https://github.com/osmosis-labs/osmosis/pull/7341) fix: support CosmWasm pools in ListPoolsByDenom method
 
 ### Misc Improvements
 

diff --git a/x/poolmanager/router.go b/x/poolmanager/router.go
@@ -577,7 +577,10 @@ func (k Keeper) ListPoolsByDenom(
 
 		var poolsByDenom []types.PoolI
 		for _, pool := range currentModulePools {
-			poolDenoms := pool.GetPoolDenoms(ctx)
+			poolDenoms, err := poolModule.GetPoolDenoms(ctx, pool.GetId())
+			if err != nil {
+				return nil, err
+			}
 			if osmoutils.Contains(poolDenoms, denom) {
 				poolsByDenom = append(poolsByDenom, pool)
 			}

diff --git a/x/poolmanager/router_test.go b/x/poolmanager/router_test.go
@@ -3870,6 +3870,14 @@ func (suite *KeeperTestSuite) TestListPoolsByDenom() {
 			denom:            BAR,
 			expectedNumPools: 2,
 		},
+		"A cosmwasm pool": {
+			poolType: []types.PoolType{types.CosmWasm},
+			poolCoins: []sdk.Coins{
+				sdk.NewCoins(sdk.NewCoin(BAR, defaultInitPoolAmount), sdk.NewCoin(UOSMO, defaultInitPoolAmount)), // pool 1 bar-uosmo
+			},
+			denom:            BAR,
+			expectedNumPools: 1,
+		},
 	}
 
 	for name, tc := range tests {