Fix insufficient total share creation

osmosis-labs · Jun 8, 2022 · 57b3a0b · 57b3a0b
1 parent 94a3878
commit 57b3a0b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/x/gamm/pool-models/balancer/amm.go b/x/gamm/pool-models/balancer/amm.go
@@ -293,8 +293,6 @@ func (p *Pool) CalcJoinPoolShares(_ sdk.Context, tokensIn sdk.Coins, swapFee sdk
 		poolAssetsByDenom[coin.Denom] = poolAsset
 	}
 
-	totalShares = totalShares.Add(numShares)
-
 	// If there are coins that couldn't be perfectly joined, do single asset joins
 	// for each of them.
 	if !remCoins.Empty() {
@@ -309,6 +307,8 @@ func (p *Pool) CalcJoinPoolShares(_ sdk.Context, tokensIn sdk.Coins, swapFee sdk
 		}
 	}
 
+	totalShares = totalShares.Add(numShares)
+
 	return numShares, newLiquidity, nil
 }