Add extra tests / examples of lockable ranges #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add range iterator example Add locked values re-mapping example Add locked values skipping example
maurolacy
force-pushed
the
extra-lockable-tests
branch
from
fb1a7f8 to
4ecf6b6
Compare
maurolacy
force-pushed
the
extra-lockable-tests
branch
from
2fce5fb to
5ce8463
Compare
ethanfrey
approved these changes
Jun 19, 2023
| .unwrap_err(); | ||
| assert_eq!(err, TestsError::Lock(LockError::WriteLocked)); | ||
|
|
||
| // But we can re-map (perhaps not a good idea) the write-locked values |
There was a problem hiding this comment.
Nice to explain what is and is not possible here
ethanfrey
reviewed
Jun 19, 2023
| .unwrap(); | ||
| assert_eq!(collaterals.len(), 3); | ||
|
|
||
| // Or we can skip (perhaps not a good idea either) the write-locked values |
There was a problem hiding this comment.
Reflecting more on this, I think the best would be to return:
enum MaybeAccount {
Account(Account),
Locked{ user: String },
}Or something Similar. (Not sure how you use the keys).
I can make an example as follow up PR (unless this makes sense to you and you want to try)
There was a problem hiding this comment.
👍🏼 Will implement this for reference / as an example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more tests / examples of using our new
Lockableprimitive in range iterators.Found useful writing these to reason about and learn how to use them.