Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move ibc workaround methods in ExternalStaking to interface #117

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

jawoznia
Copy link
Contributor

@jawoznia jawoznia commented Aug 29, 2023

Example usage of interface to keep test workaround methods out of contract

Copy link
Collaborator

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would like to avoid the need for this, but good for clarity / clean code.

@@ -55,6 +54,7 @@ pub struct ExternalStakingContract<'a> {
#[contract]
#[error(ContractError)]
#[messages(cross_staking_api as CrossStakingApi)]
#[messages(crate::test_methods as TestMethods)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@jawoznia jawoznia marked this pull request as ready for review August 31, 2023 09:12
@jawoznia jawoznia merged commit 96b9970 into remove_cross_staking_mock Aug 31, 2023
@maurolacy maurolacy deleted the move_test_methods_to_interface branch November 6, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants