Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v24: bump gogoproto to gogoproto v1.4.11 and golang.org/x/exp to latest #608

Closed
wants to merge 2 commits into from

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented May 11, 2024

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@p0mvn p0mvn changed the title bump gogoproto to gogoproto v1.4.11 and golang.org/x/exp to latest v24: bump gogoproto to gogoproto v1.4.11 and golang.org/x/exp to latest May 11, 2024
@p0mvn p0mvn marked this pull request as draft May 11, 2024 22:30
@julienrbrt
Copy link

julienrbrt commented May 11, 2024

Lucky that you can do this, we can't do that on the main line v0.47.x (no api break introduction in patch releases).
Do you have dependencies that already migrated to a later version of x/exp? If so, we may need to force the update to everyone in a later patch release.

@p0mvn
Copy link
Member Author

p0mvn commented May 12, 2024

Yep, mainly did this to experiment with flight recordings from exp in our off-chain server:

osmosis-labs/sqs#216

Already tested, and it works great. Now, running a node to confirm no state breaks

@p0mvn p0mvn marked this pull request as ready for review May 14, 2024 20:12
@p0mvn p0mvn closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants