-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove IAVL per-get/delete timing info #603
Conversation
WalkthroughThe recent update involves modifications to the telemetry measurement handling within the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed on this, thanks
its already removed upstream, nice |
Co-authored-by: Adam Tucker <[email protected]> (cherry picked from commit e8c4bae)
Co-authored-by: Adam Tucker <[email protected]> (cherry picked from commit e8c4bae) Co-authored-by: Dev Ojha <[email protected]>
Co-authored-by: Adam Tucker <[email protected]>
Remove timing info from every IAVL get/delete call.
Varies between .5 to 1% speedups to blocksync, and I have never once used this telemetry info.
Summary by CodeRabbit
Get
,Has
, andDelete
operations to enhance performance tracking.