Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: iavl async pruning (backport #593) #599

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Apr 8, 2024

Description

  • introduce new interfaces SetCommitting and UnsetCommitting to block the pruning on the iavl side

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Summary by CodeRabbit

  • New Features

    • Implemented asynchronous pruning to enhance performance.
    • Added functionality to mark store states as committing or not, improving transaction handling and state management.
  • Tests

    • Introduced delays in test scenarios to better simulate consensus processes and ensure accurate pruning behavior during commits.

This is an automatic backport of pull request #593 done by [Mergify](https://mergify.com).

* iavl async pruning

* go mod tidy

---------

Co-authored-by: Adam Tucker <[email protected]>
(cherry picked from commit 0a12f99)
@czarcas7ic czarcas7ic merged commit 2176742 into osmo-v23/v0.47.5-iavl-v1 Apr 8, 2024
22 checks passed
@czarcas7ic czarcas7ic deleted the mergify/bp/osmo-v23/v0.47.5-iavl-v1/pr-593 branch April 8, 2024 22:18
Comment on lines +484 to +486
for _, store := range rs.stores {
store.SetCommitting()
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
Comment on lines +491 to +493
for _, store := range rs.stores {
store.UnsetCommitting()
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants