feat: batch size with tmdb wrapper #582
Conversation
WalkthroughThe modifications introduce a more efficient way to handle data in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- store/wrapper/tmdb.go (4 hunks)
Additional comments: 8
store/wrapper/tmdb.go (8)
- 4-4: The addition of the
encoding/binaryimport is appropriate given its usage in theSetandDeletemethods for calculating sizes. Good practice to include only necessary imports.- 44-44: Removing type assertions in the
IteratorandReverseIteratorfunctions can enhance performance and readability. Ensure that the returned types conform to theiavldb.Iteratorinterface.- 74-74: The addition of the
sizefield in theBatchWrapperstruct is a crucial enhancement for tracking the size of batch operations. This aligns well with the PR's objectives to optimize batch processing.- 82-82: The logic to calculate the size of operations in the
Setmethod is correctly implemented. Consider defining constants for the magic numbers (e.g.,1 + binary.MaxVarintLen32) for better readability and maintainability.- 87-87: Similarly, the
Deletemethod's size calculation is appropriate. As with theSetmethod, using constants for the magic numbers could enhance code readability and maintainability.- 92-92: Resetting the
sizefield in theWritemethod is appropriate for accurately tracking the size of subsequent batch operations.- 97-97: Similarly, resetting the
sizefield in theWriteSyncmethod is correctly implemented and necessary for accurate size tracking.- 106-106: Modifying the
GetByteSizemethod to return the calculatedsizeis a key enhancement for optimizing batch processing. This aligns well with the PR's objectives.
(cherry picked from commit dead65a) # Conflicts: # store/wrapper/tmdb.go
(cherry picked from commit dead65a)
(cherry picked from commit dead65a) Co-authored-by: cool-developer <[email protected]>
This reverts commit dead65a.
Description
Unblock the
BatchWithFlusherof the iavl/v1. Maybe it won't get the full advantage sinceNewBatchWithSizeis not fully implemented.Following the goleveldb approach to calc the batch size.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change