Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: edge case in-place-testnet states #531

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

czarcas7ic
Copy link
Member

@czarcas7ic czarcas7ic commented Feb 21, 2024

Description

Closes: #XXXX

Killing a node, setting a halt height, and gracefully shutting down cause varying states of the block height across app/blockStore/state. This PR handles these states properly.

Additionally, there was an edge case where if prometheus was enabled, it would panic due to setting it a second time in testnetify. We don't actually need the metrics provider to match what the user wants in testnetify since this is just used temporarily while setting up the application, so we use the default config of instrumentation to prevent this panic from happening.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

server/start.go Fixed Show fixed Hide fixed
@czarcas7ic czarcas7ic marked this pull request as draft February 21, 2024 22:20
@czarcas7ic czarcas7ic marked this pull request as ready for review February 22, 2024 00:24
@czarcas7ic czarcas7ic merged commit d60a4bf into osmo/v0.47.5 Feb 22, 2024
22 checks passed
@czarcas7ic czarcas7ic deleted the adam/prometheus-edge-case branch February 22, 2024 00:35
mergify bot pushed a commit that referenced this pull request Feb 22, 2024
* fix prometheus edge case

* fix halt height edge cases

* figured out sigterm case

* revert load commit step

(cherry picked from commit d60a4bf)
czarcas7ic added a commit that referenced this pull request Feb 22, 2024
* fix prometheus edge case

* fix halt height edge cases

* figured out sigterm case

* revert load commit step

(cherry picked from commit d60a4bf)

Co-authored-by: Adam Tucker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant