feat: iavl v1 #528
Merged
feat: iavl v1 #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
czarcas7ic
commented
Feb 20, 2024
czarcas7ic
commented
Feb 20, 2024
| @@ -626,6 +626,7 @@ func (rs *Store) PruneStores(clearPruningManager bool, pruningHeights []int64) ( | |||
| } | |||
|
|
|||
| rs.logger.Debug("pruning store", "heights", pruningHeights) | |||
| pruneHeight := pruningHeights[len(pruningHeights)-1] | |||
There was a problem hiding this comment.
This is making the assumption that the last index pruneHeight is the largest height.
czarcas7ic
commented
Feb 20, 2024
.golangci.yml
Outdated
| @@ -40,10 +39,13 @@ issues: | |||
| - text: "ST1016:" | |||
| linters: | |||
| - stylecheck | |||
| - path: "migrations" | |||
| text: "SA1019:" | |||
| - text: "SA1019:" | |||
There was a problem hiding this comment.
This was popping for a lot of the IAVL changes, I think b/c we are using a wrapper, so I silenced them here by removing the "migrations" path. Might be a little overkill but I was spending too much time fixing this linter
czarcas7ic
commented
Feb 20, 2024
.golangci.yml
Outdated
Comment on lines
45
to
48
| - path: "crypto/keyring" | ||
| text: "G306:" | ||
| linters: | ||
| - gosec |
There was a problem hiding this comment.
Some file has 0500 privileges and the lint was expecting 0600 or higher, seems unhelpful.
czarcas7ic
commented
Feb 20, 2024
x/gov/simulation/operations_test.go
Outdated
| @@ -152,7 +152,7 @@ func TestSimulateMsgSubmitProposal(t *testing.T) { | |||
| require.True(t, operationMsg.OK) | |||
| require.Equal(t, "cosmos1ghekyjucln7y67ntx7cf27m9dpuxxemn4c8g4r", msg.Proposer) | |||
| require.NotEqual(t, len(msg.InitialDeposit), 0) | |||
| require.Equal(t, "560969stake", msg.InitialDeposit[0].String()) | |||
| require.Equal(t, "47841094stake", msg.InitialDeposit[0].String()) | |||
There was a problem hiding this comment.
czarcas7ic
commented
Feb 20, 2024
x/gov/simulation/operations_test.go
Outdated
| @@ -182,7 +182,7 @@ func TestSimulateMsgSubmitLegacyProposal(t *testing.T) { | |||
| require.True(t, operationMsg.OK) | |||
| require.Equal(t, "cosmos1p8wcgrjr4pjju90xg6u9cgq55dxwq8j7u4x9a0", msg.Proposer) | |||
| require.NotEqual(t, len(msg.InitialDeposit), 0) | |||
| require.Equal(t, "13430055stake", msg.InitialDeposit[0].String()) | |||
| require.Equal(t, "25166256stake", msg.InitialDeposit[0].String()) | |||
There was a problem hiding this comment.
ValarDragon
reviewed
Feb 21, 2024
Comment on lines
+54
to
+56
| func (db *DBWrapper) NewBatchWithSize(size int) cdbm.Batch { | ||
| return NewCosmosBatch(db.db.NewBatch()) | ||
| } |
There was a problem hiding this comment.
This is the db.Grow bug, we need to do batch with size. We can merge this as-is and fix in a followup, but this is a real win for epoch. (Extra 7 seconds on IAVL v1)
There was a problem hiding this comment.
Will wait a little longer to see if they do a release by end of day
czarcas7ic
added
A:backport/v23-iavl-v1
A:backport/v23
and removed
A:backport/v23-iavl-v1
labels
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
* final iavl v1 implementation * bump go1.19 to 1.20 * go mod tidy * inc golang in CI * codeQL * Revert "codeQL" This reverts commit 1b1366b. * try to inc version for linter * adds config * fix config path * Revert "fix config path" This reverts commit 6498b69. * Revert "adds config" This reverts commit ae6cd9c. * golang ci fixes * fix gov simulation * fix values * remove explicit config location call * remove unnecessary CI check * remove unnecessary go bumps (cherry picked from commit f09bb25)
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
* final iavl v1 implementation * bump go1.19 to 1.20 * go mod tidy * inc golang in CI * codeQL * Revert "codeQL" This reverts commit 1b1366b. * try to inc version for linter * adds config * fix config path * Revert "fix config path" This reverts commit 6498b69. * Revert "adds config" This reverts commit ae6cd9c. * golang ci fixes * fix gov simulation * fix values * remove explicit config location call * remove unnecessary CI check * remove unnecessary go bumps (cherry picked from commit f09bb25)
czarcas7ic
added a commit
that referenced
this pull request
Feb 22, 2024
* final iavl v1 implementation * bump go1.19 to 1.20 * go mod tidy * inc golang in CI * codeQL * Revert "codeQL" This reverts commit 1b1366b. * try to inc version for linter * adds config * fix config path * Revert "fix config path" This reverts commit 6498b69. * Revert "adds config" This reverts commit ae6cd9c. * golang ci fixes * fix gov simulation * fix values * remove explicit config location call * remove unnecessary CI check * remove unnecessary go bumps (cherry picked from commit f09bb25) Co-authored-by: Adam Tucker <[email protected]>
czarcas7ic
added a commit
that referenced
this pull request
Apr 9, 2024
This reverts commit f09bb25.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
IAVL v1 implementation.
After merge, create a v23 branch that is the same as the current v23 branch, but with this commit.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...