forked from cosmos/cosmos-sdk
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: distribute every 50 blocks #527
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czarcas7ic
changed the title
feat: distribute every 10 blocks
feat: distribute every 20 blocks
Feb 15, 2024
ValarDragon
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice job!
Note this would only work for us, not SDK, since we don't care about vote inclusion amounts for reward distr in Osmosis. |
czarcas7ic
changed the title
feat: distribute every 20 blocks
feat: distribute every 50 blocks
Feb 16, 2024
czarcas7ic
added a commit
that referenced
this pull request
May 9, 2024
* distribute every 10 blocks * total power logic in loop * distribute on block height 2 as well * set distribution to each block for tests * remove special case for test * add test displaying delayed logic * add clarifying comments, change to 20 * remove block height 2 hack * comment * Update allocation_test.go * test fixes, up to 50 blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
The distribution module runs distribution logic every block. This is unnecessary overhead. We can hold off this logic to instead run every 50 blocks.