Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: distribute every 50 blocks #527

Merged
merged 12 commits into from
Feb 16, 2024

Conversation

czarcas7ic
Copy link
Member

@czarcas7ic czarcas7ic commented Feb 15, 2024

Description

Closes: #XXXX

The distribution module runs distribution logic every block. This is unnecessary overhead. We can hold off this logic to instead run every 50 blocks.

@czarcas7ic czarcas7ic marked this pull request as draft February 15, 2024 05:58
@czarcas7ic czarcas7ic changed the title feat: distribute every 10 blocks feat: distribute every 20 blocks Feb 15, 2024
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job!

@ValarDragon
Copy link
Member

Note this would only work for us, not SDK, since we don't care about vote inclusion amounts for reward distr in Osmosis.

@czarcas7ic czarcas7ic changed the title feat: distribute every 20 blocks feat: distribute every 50 blocks Feb 16, 2024
@czarcas7ic czarcas7ic closed this Feb 16, 2024
@czarcas7ic czarcas7ic reopened this Feb 16, 2024
@czarcas7ic czarcas7ic marked this pull request as ready for review February 16, 2024 05:18
@czarcas7ic czarcas7ic merged commit 3d440de into osmo/v0.47.5 Feb 16, 2024
23 checks passed
@czarcas7ic czarcas7ic deleted the adam/distribute-every-10-blocks branch February 16, 2024 06:06
czarcas7ic added a commit that referenced this pull request May 9, 2024
* distribute every 10 blocks

* total power logic in loop

* distribute on block height 2 as well

* set distribution to each block for tests

* remove special case for test

* add test displaying delayed logic

* add clarifying comments, change to 20

* remove block height 2 hack

* comment

* Update allocation_test.go

* test fixes, up to 50 blocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants