feat: add testnetify logic #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Height: state.LastBlockHeight, | ||
| Round: 0, | ||
| BlockID: state.LastBlockID, | ||
| Timestamp: time.Now(), |
Check warning
Code scanning / CodeQL
Calling the system time Warning
p0mvn
reviewed
Jan 28, 2024
server/types/app.go
Outdated
Comment on lines
77
to
79
| // TestnetAppCreator serves a similar purpose as AppCreator, however is used for | ||
| // passing more information to the application layer needed to create a testnet from existing state. | ||
| TestnetAppCreator func(log.Logger, dbm.DB, io.Writer, bytes.HexBytes, crypto.PubKey, string, AppOptions) Application |
There was a problem hiding this comment.
Could we pass more information as AppOptions to avoid duplicating API and, as a result, parameters to startInProcess?
There was a problem hiding this comment.
Really good suggestion, am implementing now.
I thought it wasn't possible to type case the viper inputs that come from AppOptions to anything other than native types but that is not the case.
12 tasks
czarcas7ic
added a commit
that referenced
this pull request
Feb 8, 2024
* De-dup param getting * Disable DenomOwners tracking * Fix some tests * chore(types): replace amino json encoder with stdlib * feat: config option to log gRPC queries (#503) * config option to log gRPC queries * clarify gRPC log comment * create var * remove quotes * go mod tidy * chore: fix CI (#509) * ci * lints and remove some unnecessary CI jobs * update tests go mod * more lints * remove denom owners since not implemented in osmosis * more lints * fix test values * implement nolint again * more test fixes * add back labeler as v4 * remove tabs and slash * update json to const * move file locations * push * fix seq num issue * Update tests/e2e/auth/vesting/suite.go * add back pwd * remove sonarcloud --------- Co-authored-by: Matt, Park <[email protected]> * Fix CI(#511) * perf: CacheCtx speedups (#504) * CacheKV speedups * Remove extra btree alloc * fix(x/feegrant)!: limit expired feegrant pruning to 200 per block (cosmos#19314) (#512) Co-authored-by: MSalopek <[email protected]> * feat: add testnetify logic (#506) * add testnetify logic * clarify explanation * handle errors * remove testnet app creator * simplify some logic * remove redundancy * lints * gci imports * add set store loader method * trigger upgrade flag * add extra comments to the CLI command * skip confirmation (#516) --------- Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: Matt, Park <[email protected]> Co-authored-by: MSalopek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
This PR adds the required logic for creating a testnet from mainnet state. This PR will be upstreamed to the SDK as soon as we merge it here, and plug in the required logic to the osmosis repo.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change