feat: Add convenience method for constructing key to access account's balance for a given denom #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… balance for a given denom (backport cosmos#12674) (cosmos#12745) * feat: Add convenience method for constructing key to access account's balance for a given denom (cosmos#12674) This PR adds a convenience method for constructing the key necessary to query for the account's balance of a given denom. I ran into this issue since we are using ABCI query now to perform balance requests because we are also requesting merkle proofs for the returned balance [here](https://github.com/celestiaorg/celestia-node/pull/911/files#diff-0ee31f5a7bd88e9f758e6bebdf3ee36365519e55a451098d9638c39afe5eac42R144). It would be nice to have a definitive convenience method for constructing the key. [Ref.](github.com/celestiaorg/celestia-node/pull/911) (cherry picked from commit a1777a8) * Update CHANGELOG.md * fix conflict Co-authored-by: rene <[email protected]> Co-authored-by: Marko <[email protected]>
| @@ -90,13 +90,13 @@ func TestBalanceKeysMigration(t *testing.T) { | |||
| err = v043bank.MigrateStore(ctx, bankKey, encCfg.Marshaler) | |||
| require.NoError(t, err) | |||
|
|
|||
| newKey := append(types.CreateAccountBalancesPrefix(addr), []byte(fooCoin.Denom)...) | |||
| newKey := types.CreatePrefixedAccountStoreKey(addr, []byte(fooCoin.Denom)) | |||
There was a problem hiding this comment.
IMO the caller shouldn't have to cast into a byte slice -- have CreatePrefixedAccountStoreKey do it for them :)
There was a problem hiding this comment.
Agreed, but should we keep this consistent with upstream to ease future backports / rebases?
There was a problem hiding this comment.
This is just test shouldn't matter much right?
There was a problem hiding this comment.
Is this what core SDK does? Sigh...
p0mvn
approved these changes
Oct 13, 2022
mergify bot
pushed a commit
that referenced
this pull request
Oct 13, 2022
… balance for a given denom (backport cosmos#12674) (cosmos#12745) (#352) * feat: Add convenience method for constructing key to access account's balance for a given denom (cosmos#12674) This PR adds a convenience method for constructing the key necessary to query for the account's balance of a given denom. I ran into this issue since we are using ABCI query now to perform balance requests because we are also requesting merkle proofs for the returned balance [here](https://github.com/celestiaorg/celestia-node/pull/911/files#diff-0ee31f5a7bd88e9f758e6bebdf3ee36365519e55a451098d9638c39afe5eac42R144). It would be nice to have a definitive convenience method for constructing the key. [Ref.](github.com/celestiaorg/celestia-node/pull/911) (cherry picked from commit a1777a8) * Update CHANGELOG.md * fix conflict Co-authored-by: rene <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: rene <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: Roman <[email protected]> (cherry picked from commit c6b1e6a)
p0mvn
pushed a commit
that referenced
this pull request
Oct 14, 2022
… balance for a given denom (backport cosmos#12674) (cosmos#12745) (#352) (#365) * feat: Add convenience method for constructing key to access account's balance for a given denom (cosmos#12674) This PR adds a convenience method for constructing the key necessary to query for the account's balance of a given denom. I ran into this issue since we are using ABCI query now to perform balance requests because we are also requesting merkle proofs for the returned balance [here](https://github.com/celestiaorg/celestia-node/pull/911/files#diff-0ee31f5a7bd88e9f758e6bebdf3ee36365519e55a451098d9638c39afe5eac42R144). It would be nice to have a definitive convenience method for constructing the key. [Ref.](github.com/celestiaorg/celestia-node/pull/911) (cherry picked from commit a1777a8) * Update CHANGELOG.md * fix conflict Co-authored-by: rene <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: rene <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: Roman <[email protected]> (cherry picked from commit c6b1e6a) Co-authored-by: Matt, Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport : cosmos#12745