Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move grpcConcurrency to config.toml #344

Merged
merged 1 commit into from
Oct 10, 2022
Merged

chore: move grpcConcurrency to config.toml #344

merged 1 commit into from
Oct 10, 2022

Conversation

czarcas7ic
Copy link
Member

@czarcas7ic czarcas7ic commented Oct 7, 2022 •
edited
Loading

What is the purpose of the change

Moves grpcConcurrency config from client.toml to config.toml.

Brief Changelog

  • Removed grpcConcurreny flag (do we think this is the right move? I felt like grpcConcurrency should just be something set at the config level, not something that should be defined at the query level. If not, I can change this back. Side note, the flag was never really implemented correctly in the first place)
  • Removed grpcConcurrency from client.toml
  • Created new test case for grpcConcurrency
  • Added grpcConcurrency to config.toml

Testing and Verifying

This change is already covered by existing tests

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@github-actions github-actions bot added the C:CLI label Oct 7, 2022
@czarcas7ic czarcas7ic changed the title chore: move grpcConcurrency to correct location chore: move grpcConcurrency to config.toml Oct 7, 2022
@czarcas7ic czarcas7ic marked this pull request as ready for review October 7, 2022 01:37
@czarcas7ic czarcas7ic requested a review from a team October 7, 2022 01:37
mattverse
mattverse approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@czarcas7ic czarcas7ic merged commit d2f1cb4 into osmosis-main Oct 10, 2022
@czarcas7ic czarcas7ic deleted the adam/move-grpc-concur branch October 10, 2022 23:11
@mergify mergify bot mentioned this pull request Oct 10, 2022
Merged
mergify bot pushed a commit that referenced this pull request Oct 10, 2022
@czarcas7ic @mergify
initial grpc concurrency move (#344)
c446396 
(cherry picked from commit d2f1cb4)
czarcas7ic added a commit that referenced this pull request Oct 11, 2022
@mergify @czarcas7ic
chore: move grpcConcurrency to config.toml (backport #344) (#346)
cd9d50d 
* initial grpc concurrency move (#344)

(cherry picked from commit d2f1cb4)

* fix test

Co-authored-by: Adam Tucker <[email protected]>
Co-authored-by: Adam Tucker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@mattverse mattverse mattverse approved these changes

Assignees
No one assigned
Labels
C:CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@czarcas7ic @alexanderbez @mattverse