fix: ICA export genesis patch #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
approved these changes
Oct 4, 2022
| @@ -33,6 +33,9 @@ func NewGenesisState(params Params, accounts GenesisAccounts) *GenesisState { | |||
| func (g GenesisState) UnpackInterfaces(unpacker types.AnyUnpacker) error { | |||
| for _, any := range g.Accounts { | |||
| var account GenesisAccount | |||
| if any.TypeUrl == "/ibc.applications.interchain_accounts.v1.InterchainAccount" { | |||
There was a problem hiding this comment.
Also might be better to call MsgType on the type directly instead of a hard-coded string in case it changes.
There was a problem hiding this comment.
we didn't implement ICA correctly in v11, so at some height when someone on mainnet created an ICA it errors the export
There was a problem hiding this comment.
IRT the type vs hard code, this is no longer needed in v12 so even if this changed in the future it would not affect this AFAIU!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
During v11 I had a custom branch I and others used to get passed an ICA bug when doing a state export. This implements the fix in our v11 sdk fork which will then be backported to v11x (and maybe a minor release?) so that if someone needs to state export v11 height in the future they are able to.