Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): backports to v9 #301

Closed
wants to merge 3 commits into from
Closed

fix(ci): backports to v9 #301

wants to merge 3 commits into from

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Jul 27, 2022

Closes: #XXX

What is the purpose of the change

backports to v9 are not working. This is an attempt to fix them.

@p0mvn p0mvn force-pushed the roman/fix-backport branch from c61a24d to ef13393 Compare July 27, 2022 22:36
@github-actions github-actions bot added Type: CI and removed C:x/gov labels Jul 27, 2022
@p0mvn p0mvn marked this pull request as ready for review July 27, 2022 22:55
@p0mvn p0mvn requested a review from a team July 27, 2022 22:55
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh interesting is the claim of the PR that backport v9 wasn't working because it didn't have a whitespace between the two CI jobs in the mergify yml file?

Copy link

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get it haha. This is just a newline addition....

@p0mvn
Copy link
Member Author

p0mvn commented Aug 10, 2022

I couldn't figure out why that was the only label not working. So I made a guess that it is due to formatting / not being parsed correctly haha.

This was the only visual difference I observed. I also verified label names by character and they seem to match

@alexanderbez
Copy link

mhh I don't think it would be a new line. Perhaps the label is wrong or maybe doesn't exist?

@mattverse
Copy link
Member

I don't think it would hurt to try if thats the only difference, Im down to merging this

@p0mvn
Copy link
Member Author

p0mvn commented Aug 18, 2022

Just spent some time looking into this more.

Mergify has a nice dashboard where we it is possible to check if the configuration is applied correctly: https://dashboard.mergify.com/github/osmosis-labs/repo/cosmos-sdk/

According to that dashboard, the rules were getting picked up without the whitespace change here.

So I moved to my personal fork to debug this further. Then, I noticed that I could not push v0.45.0x-osmo-v9 branch to my fork remote because there was a clash between the branch name and the tag.

It looks like mergify was getting confused for the same reason.

After deleting the erroneous v0.45.0x-osmo-v9 tag, the mergify backported the latest PR correctly: #314

Apologies for this PR that wasn't very useful after all

@p0mvn p0mvn closed this Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants