-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): backports to v9 #301
Conversation
de32b4c
to
c61a24d
Compare
c61a24d
to
ef13393
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh interesting is the claim of the PR that backport v9 wasn't working because it didn't have a whitespace between the two CI jobs in the mergify yml file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get it haha. This is just a newline addition....
I couldn't figure out why that was the only label not working. So I made a guess that it is due to formatting / not being parsed correctly haha. This was the only visual difference I observed. I also verified label names by character and they seem to match |
mhh I don't think it would be a new line. Perhaps the label is wrong or maybe doesn't exist? |
I don't think it would hurt to try if thats the only difference, Im down to merging this |
Just spent some time looking into this more. Mergify has a nice dashboard where we it is possible to check if the configuration is applied correctly: https://dashboard.mergify.com/github/osmosis-labs/repo/cosmos-sdk/ According to that dashboard, the rules were getting picked up without the whitespace change here. So I moved to my personal fork to debug this further. Then, I noticed that I could not push It looks like mergify was getting confused for the same reason. After deleting the erroneous Apologies for this PR that wasn't very useful after all |
Closes: #XXX
What is the purpose of the change
backports to v9 are not working. This is an attempt to fix them.