refactor: snapshot manager is created independently from snapshot-int… #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you like me to PR this on v7.x as well to test on mainnet? |
Thank you but I don't think this change is risky so we can just proceed with it on v8 |
alexanderbez
approved these changes
May 12, 2022
p0mvn
added a commit
that referenced
this pull request
Jun 7, 2022
#236) (#255) (cherry picked from commit 0041954) Co-authored-by: Roman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #235
What is the purpose of the change
Earlier snapshot refactor made state-sync work only when
snapshot-intervalis > 0. State-sync should be enabled even when asnapshot-intervalis 0. This PR makes it so.Testing and Verifying
This change is already covered by existing tests, such as (please describe tests).
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? no