Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra logs during commit #146

Merged
merged 2 commits into from
Mar 21, 2022
Merged

extra logs during commit #146

merged 2 commits into from
Mar 21, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Mar 21, 2022

Description

This is to help with root causing: osmosis-labs/osmosis#1090

Currently, the provided logs are inconclusive. So far I can only tell that the faulty node ends up with an app hash that is different from the rest of the network. These extra logs should, hopefully, help us understand which store exactly has a different hash from the rest of the network. Also, if there is any relationship to pruning.

@p0mvn p0mvn requested a review from ValarDragon March 21, 2022 03:32
@p0mvn p0mvn changed the title WIP: extra logs during commit extra logs during commit Mar 21, 2022
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Eventually several of the commit kv store log should move to debug, but that can be done when it gets into a major release

@p0mvn
Copy link
Member Author

p0mvn commented Mar 21, 2022

LGTM! Eventually several of the commit kv store log should move to debug, but that can be done when it gets into a major release

Created issue: #148

Adding this to the database stability epic so that it is not missed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants