perf(p2p): Remove unnecessary atomic read (backport #2950) (#2972) #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ometbft#2972) This PR is a driveby change. We were doing an atomic read here, but this is unnecessary. Nothing in the codebase modified this variable after instantiation. Doesn't really feel changelog worthy, but I can add one if we want. Felt like a minor code nit<hr>This is an automatic backport of pull request cometbft#2950 done by [Mergify](https://mergify.com). Co-authored-by: Dev Ojha <[email protected]>
czarcas7ic
added
S:backport/v24
mergify bot
pushed a commit
that referenced
this pull request
May 3, 2024
…ometbft#2972) (#41) This PR is a driveby change. We were doing an atomic read here, but this is unnecessary. Nothing in the codebase modified this variable after instantiation. Doesn't really feel changelog worthy, but I can add one if we want. Felt like a minor code nit<hr>This is an automatic backport of pull request cometbft#2950 done by [Mergify](https://mergify.com). Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Dev Ojha <[email protected]> (cherry picked from commit c1cebed)
3 tasks
mergify bot
pushed a commit
that referenced
this pull request
May 3, 2024
…ometbft#2972) (#41) This PR is a driveby change. We were doing an atomic read here, but this is unnecessary. Nothing in the codebase modified this variable after instantiation. Doesn't really feel changelog worthy, but I can add one if we want. Felt like a minor code nit<hr>This is an automatic backport of pull request cometbft#2950 done by [Mergify](https://mergify.com). Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Dev Ojha <[email protected]> (cherry picked from commit c1cebed)
3 tasks
czarcas7ic
added a commit
that referenced
this pull request
May 3, 2024
…ometbft#2972) (#41) (#50) This PR is a driveby change. We were doing an atomic read here, but this is unnecessary. Nothing in the codebase modified this variable after instantiation. Doesn't really feel changelog worthy, but I can add one if we want. Felt like a minor code nit<hr>This is an automatic backport of pull request cometbft#2950 done by [Mergify](https://mergify.com). Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Dev Ojha <[email protected]> (cherry picked from commit c1cebed) Co-authored-by: Adam Tucker <[email protected]>
czarcas7ic
added a commit
that referenced
this pull request
May 3, 2024
…ometbft#2972) (#41) (#51) This PR is a driveby change. We were doing an atomic read here, but this is unnecessary. Nothing in the codebase modified this variable after instantiation. Doesn't really feel changelog worthy, but I can add one if we want. Felt like a minor code nit<hr>This is an automatic backport of pull request cometbft#2950 done by [Mergify](https://mergify.com). Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Dev Ojha <[email protected]> (cherry picked from commit c1cebed) Co-authored-by: Adam Tucker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a driveby change. We were doing an atomic read here, but this is unnecessary. Nothing in the codebase modified this variable after instantiation.
Doesn't really feel changelog worthy, but I can add one if we want. Felt like a minor code nit
This is an automatic backport of pull request cometbft#2950 done by Mergify.
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments