feat: VerifyCommitLight and VerifyCommitLightTrusting _never_ check all signatures
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czarcas7ic
changed the title
VerifyCommitLight and VerifyCommitLightTrusting _never_ check all signatures
czarcas7ic
commented
Feb 25, 2024
| @@ -132,19 +132,19 @@ func (evpool *Pool) Update(state sm.State, ev types.EvidenceList) { | |||
|
|
|||
| // AddEvidence checks the evidence is valid and adds it to the pool. | |||
| func (evpool *Pool) AddEvidence(ev types.Evidence) error { | |||
| evpool.logger.Debug("Attempting to add evidence", "ev", ev) | |||
| evpool.logger.Info("Attempting to add evidence", "ev", ev) | |||
There was a problem hiding this comment.
Do these really need to be info logs? If not im switching them back
There was a problem hiding this comment.
Its fine to add them as Info, evidence is rare
czarcas7ic
changed the base branch from
adam/batch-verfy-backport
to
osmo/v0.37.4
ValarDragon
reviewed
Feb 26, 2024
blocksync/reactor.go
Outdated
| @@ -373,7 +373,8 @@ FOR_LOOP: | |||
| // NOTE: we can probably make this more efficient, but note that calling | |||
| // first.Hash() doesn't verify the tx contents, so MakePartSet() is | |||
| // currently necessary. | |||
| err = state.Validators.VerifyCommitLight( | |||
| // TODO(sergio): Should we also validate against the extended commit? | |||
| err = state.Validators.VerifyCommitLightAllSignatures( | |||
There was a problem hiding this comment.
Either we should undo this line, or backport https://github.com/cometbft/cometbft/pull/1858/files as well
There was a problem hiding this comment.
Done here, will merge and backport after tests pass, thank you
czarcas7ic
added a commit
that referenced
this pull request
Feb 27, 2024
feat: `VerifyCommitLight` and `VerifyCommitLightTrusting` _never_ check all signatures
czarcas7ic
added a commit
that referenced
this pull request
Mar 6, 2024
…ckport-2" This reverts commit a4c5674.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments