Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update badge: use branch develop for coverage status #28

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

Binnette
Copy link
Collaborator

@Binnette Binnette commented Jul 5, 2024

seems like, we should reference branch develop to have the latest coveralls scan (otherwise, we have the coverage of branch main)

@PanierAvide PanierAvide merged commit dda47b3 into develop Jul 5, 2024
1 check passed
@coveralls
Copy link

Coverage Status

coverage: 74.352%. remained the same
when pulling 149122f on use-branch-develop-for-coverage
into fc675b4 on develop.

@Binnette
Copy link
Collaborator Author

Binnette commented Jul 5, 2024

@PanierAvide Seems you will need to update settings of this GitHub project to unset travis and coverage from options, since my GitHub workflow both build and test coverage

image

@PanierAvide
Copy link
Collaborator

I removed some travis webhook in config, not sure if it's enough or not (I'm not used to GitHub CI, I do more stuff in Gitlab CI usually 😅 )

@PanierAvide
Copy link
Collaborator

You're repo admin now, if you want to change things don't hesitate, that will be simpler for you 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants