Fix converting from .osc to .pbf #366
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem was that .pbf never had `has_multiple_object_versions` set to true, hence it didn't emit `HistoricalInformation` and didn't write `Visible` values in protobuf
|
Thanks for the PR. I am not sure yet whether this does fit in here or has to be solved elsewhere. I am concerned about backwards compatibility. I'll need some time to look into this properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem was that .pbf never had
has_multiple_object_versionsset to true, hence it didn't emitHistoricalInformationand didn't writeVisiblevalues in protobufPlease let me know if this belongs here(or elsewhere in this repo) or at https://github.com/osmcode/osmium-tool/blob/583db02ac9193dfb5217f93c823a4975405338ac/src/command_cat.cpp#L160
Once that is clarified I will add tests in correct repository.
P.S: Forgot to mention how to repro this...
osmium cat -o output.pbf 055.osc.gz