Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hashtag with appname in notes #16489 #18254

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

deevroman
Copy link
Contributor

@deevroman deevroman commented Sep 30, 2023

@vshcherb
Copy link
Member

vshcherb commented Oct 2, 2023

Is it a common practices for the apps? Or will it be just annoying trash as you can see in a conversation.

Osm Notes is a conversation tool and not an editor, so it shouldn't matter which messenger do you use

@deevroman
Copy link
Contributor Author

Is it a common practices for the apps?

More like yes. The most popular editors actively using notes (StreetComplete, MapsMe/OrganicMaps) add such information. And even the version + date of the maps used in the application.

Osm Notes is a conversation tool

In most cases, no. By my count, only 13% of notes have more than two comments (including the note itself). More than 5 is 1.6%, more than 10 is 0.01%. But note that such meta information is only added when the note is created. It certainly doesn't interfere with the discussion.


In Osmand's case, there are two other good reasons to add meta-information:

  1. OsmAnd allows you to add anonymous notes. Often such notes make little sense and the author cannot be contacted. Having the name of the app, will add credibility.
  2. OsmAnd's maps can lag months behind the database. As the mappers who process the notes say, it is very useful to understand the state of the OSM database as seen by the user.

@vshcherb vshcherb merged commit 0c3614f into osmandapp:master Oct 7, 2023
2 checks passed
@mmd-osm
Copy link

mmd-osm commented Oct 8, 2023

In fact hashtags in notes are somewhat controversial, maybe check for yourself: openstreetmap/openstreetmap-website#3932

@deevroman
Copy link
Contributor Author

In this case, the only thing in dispute is how the metadata about the application should look (with or without a hashtag).

The main argument in openstreetmap/openstreetmap-website#3932 is whether the notes data model should be changed. Something tells me that there will be no changes in the near future... And until there are no changes, we can only use the text of the note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants