avoid ways/rels update for non moving node updates #1059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmd-osm
reviewed
Feb 15, 2020
| slim->nodes_delete(node.id()); | ||
| slim->nodes_set(node); | ||
| osmium::Location oldnode = slim->nodes_get(node.id()); | ||
| if ( node.location().x() != oldnode.x() || node.location().y() != oldnode.y() ) { |
There was a problem hiding this comment.
osmium::Location has both == and != operators, so node.location() != oldnode should do here.
https://github.com/osmcode/libosmium/blob/master/include/osmium/osm/location.hpp#L489
mmd-osm
reviewed
Feb 15, 2020
| { | ||
| return cache->get(osm_id); | ||
| } | ||
|
|
There was a problem hiding this comment.
There are also other places in the code where nodes_get would have to be implemented, see compiler errors:
In file included from /home/travis/build/openstreetmap/osm2pgsql/tests/test-parse-extra-args.cpp:15:
/home/travis/build/openstreetmap/osm2pgsql/tests/mockups.hpp:7:8: note: because the following virtual functions are pure within ‘dummy_middle_t’:
struct dummy_middle_t : public middle_t {
^~~~~~~~~~~~~~
In file included from /home/travis/build/openstreetmap/osm2pgsql/tests/test-parse-extra-args.cpp:9:
/home/travis/build/openstreetmap/osm2pgsql/middle.hpp:91:30: note: ‘virtual osmium::Location middle_t::nodes_get(osmid_t)’
virtual osmium::Location nodes_get(osmid_t osm_id) = 0;
lonvia
force-pushed
the
1.2.x
branch
2 times, most recently
from
0ab45a6 to
7d9f3e9
Compare
|
Closing the outdated PR. We still have the open issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.