-
-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of new flex backend #1037
Conversation
d21f230
to
dbf5919
Compare
1437cb1
to
8b14c67
Compare
893ec7a
to
541a97d
Compare
63b5380
to
fb3763a
Compare
I've looked through the code and this looks good for a first experimental implementation. There might be room for consolidation with the existing code but I don't think it's worth doing that before the interface of the output is stable. I would suggest to mark this as experimental and merge this in its current state. This makes it easier for people to test the new output and also means that we can have smaller PRs with further improvements. @pnorman what do you think? @joto can you please add the flex output to the existing READMEs with a big fat warning that this is experimental and the API might change without notice. |
ebeaa03
to
cc9748f
Compare
I'm okay with this. |
This introduces a new "flex" backend which allows much more flexibility in choosing the database format and the transformation from OSM data to the database format. The user defines all this in a Lua script.
Thank you, this looks very useful. Will this be part of an official release soon? |
It will be part of the next release but I cannot give an ETA on that. We need some more testing (and more tests). So, the more people try out the master branch or volunteer tests, the sooner the release. ;) |
This PR introduces a new flex backend, see #1036 for the ideas behind this.
If you want to try this: Compile as usual, Lua support must be enabled. Then run osm2pgsql with
-O flex
and-S some-config.lua
. Docs indocs/flex.md
. Look intoflex-config
directory for some example config/style files with inline documentation. Start withsimple.lua
.This PR more or less resolves the following issues: #109, #153, #230, #277, #328, #573, #677, #734, #901
In addition this PR impacts the following issues: #107, #328, #768