check number of zones by country - POC #2
Conversation
and add html vizu
which is not used
README.md
Outdated
|
|
||
| To compute the number of zones for each kind of zones (volumetric stats) and test them again reference values, just type: | ||
|
|
||
| `py.test` |
There was a problem hiding this comment.
isn't it pipenv run py.test ?
There was a problem hiding this comment.
on a old cosmogony planet I get:
44 failed, 182 passed, 2 skipped in 2630.95 seconds
but there seems to be lots of mistakes.
I feel like the html could be more helpful and that I'd like a way to dig into the problems afterward (interactive mode in python, pg loading to query ?) but I'm ok to do this in another PR
| @@ -0,0 +1 @@ | |||
| from .index import ZonesIndex, UnknownWikidataId | |||
| try: | ||
| matched_zones = list(zones_index.iter_children( | ||
| line['wikidata_id'], | ||
| lambda z:z['zone_type']==line['zone_type'] |
There was a problem hiding this comment.
is it mandatory to filter on the zone_type ?
There was a problem hiding this comment.
zone_type is the only filter that is currently defined in the reference ".csv" file.
Do you suggest to make it optional to count all children of a zone ?
Or make this filter dynamic, depending on the columns in the csv ?
There was a problem hiding this comment.
nop I was wondering if that made sense to check also all the chlid without this filter, but I'm not sure we want this and anyway it will be for another time 😉
README.md
Outdated
|
|
||
| ### Compute and test against references values | ||
|
|
||
| You will need `python3` and a few dependancies you can install with `pipenv install`. |
There was a problem hiding this comment.
pipenv install --three will ensure the python3 version
| .pytest_cache | ||
| data_volumetric.csv | ||
| data_volumetric.json | ||
| cosmogony.geojson |
This is a POC about quality assurance tools, as described in this issue and following up the creation of this notebook.
The branch is based on PR #1.
It produces :
--
For now, it does not bring satisfaction: