Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix 20241014 #1492

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Bug fix 20241014 #1492

merged 2 commits into from
Oct 14, 2024

Conversation

WhiredPlanck
Copy link
Collaborator

Pull request

Issue tracker

Fixes will automatically close the related issues

Fixes #1485
Fixes #1491

Feature

Describe features of this pull request

Code of conduct

Code style

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub Action CI pass
  4. At least one contributor review and approve
  5. Merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

fix: could only delete candidate of first index (osfans#1491)
refactor: exclude latest tag from librime git version name
@WhiredPlanck WhiredPlanck merged commit 7b71c6f into osfans:develop Oct 14, 2024
4 checks passed
@WhiredPlanck WhiredPlanck deleted the bug-fix-20241014 branch October 14, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants