Visibility & _envoy_cc_test_infrastructure_library

In envoyproxy/nighthawk#101 we update coverage to the new methodology. For that to work we need to be able to consume `_lib_internal_only` targets which aren't visible today. This proposes a change so we can make that happen. The naming is fairly clear that these targets shouldn't be used otherwise. Signed-off-by: Otto van der Schaaf <[email protected]>
oschaaf · Jul 29, 2019 · a091e8d · a091e8d
1 parent 26ba5ae
commit a091e8d
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/bazel/envoy_test.bzl b/bazel/envoy_test.bzl
@@ -143,8 +143,8 @@ def envoy_cc_test(
         repository = repository,
         tags = test_lib_tags,
         copts = copts,
-        # Restrict only to the code coverage tools.
-        visibility = ["@envoy//test/coverage:__pkg__"],
+        # Allow public visibility so these can be consumed in coverage tests in external projects.
+        visibility = ["//visibility:public"],
     )
     native.cc_test(
         name = name,