This repository has been archived by the owner on Jun 30, 2020. It is now read-only.
Update fast-route dependency #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… conflict with "league/route".
|
@oscarotero Could you merge this one? This broken dependency is breaking all builds currently, as mentioned in #46 |
This was referenced Nov 15, 2016
|
+1 |
|
Merged!. Thank you. I'm curious about the reason why |
|
@oscarotero let's find out together! seems that league's route works with lots of fast-route versions including the most recent tags. i added highest and lowest dependency version builds. looks like the package has pretty good coverage, so we'll see what they say : ) |
|
@oscarotero my change to thephpleague/route was accepted. we might be able to loosen the dependency range now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dependency on nikic/fast-route from "0.*" to "^0.7" to resolve conflict with "league/route".