Skip to content
This repository has been archived by the owner on Jun 30, 2020. It is now read-only.

https middleware #73

Closed
jimblue opened this issue Mar 21, 2017 · 10 comments
Closed

https middleware #73

jimblue opened this issue Mar 21, 2017 · 10 comments

Comments

@jimblue
Copy link

jimblue commented Mar 21, 2017

Hello,

Actually it's not possible to activate or deactivate https middleware by passing an argument like for www middleware does :

Middleware::Www(true)

This is really useful when switching from a development to production environment.

Is it possible to add this function?

Thank you so much.

@oscarotero
Copy link
Owner

That's good idea. I'm implementing this 👍

@jimblue
Copy link
Author

jimblue commented Mar 21, 2017

Great ! :)

@oscarotero
Copy link
Owner

I've commited a fix for this. Can you check if it works fine?
Thanks

@jimblue
Copy link
Author

jimblue commented Mar 22, 2017

That's rock 😄 !

You can definitely make the release for composer hehe

Thank you so much @oscarotero

@danizord
Copy link

Hey everyone, what about using composition for that?

Middleware::Toggle(Middleware::Www(), true)
Middleware::Toggle(Middleware::Https(), false)

@jimblue
Copy link
Author

jimblue commented Mar 23, 2017

Hi!

I'm using it like this and that work well: Middleware::Www(true)

Why do you want an other way to switch on/off ?

@danizord
Copy link

danizord commented Mar 23, 2017 via email

@jimblue
Copy link
Author

jimblue commented Mar 23, 2017

OK :)

@oscarotero
Copy link
Owner

3.20 released

@jimblue
Copy link
Author

jimblue commented Mar 23, 2017

@oscarotero thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants