Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation notice on PHP 8.4 #11

Closed
fisharebest opened this issue Dec 17, 2024 · 2 comments
Closed

Deprecation notice on PHP 8.4 #11

fisharebest opened this issue Dec 17, 2024 · 2 comments

Comments

@fisharebest
Copy link
Contributor

public function __construct(array $middleware, ContainerInterface $container = null)

The line

public function __construct(array $middleware, ContainerInterface $container = null)

needs to be

public function __construct(array $middleware, ?ContainerInterface $container = null)
@oscarotero
Copy link
Owner

Thanks!
I cannot install PHP 8 in my computer (long story). Do you mind to create a PR with these changes?
And if you update also the tests, it would be great.

fisharebest added a commit to fisharebest/middleland that referenced this issue Dec 20, 2024
fisharebest added a commit to fisharebest/middleland that referenced this issue Dec 20, 2024
@fisharebest
Copy link
Contributor Author

PR created!

oscarotero added a commit that referenced this issue Jan 6, 2025
Fix: #11 - Add compatibility for PHP 8.4. Drop compatibility with PHP 7.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants