v4: Prevent adding the same translator comment to multiple functions #271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a while since my last my PR to this project.
You might recall that we're using this library in WP-CLI for string extraction in all of WordPress core and WordPress plugins.
Unfortunately due to different minimum PHP version requirements (still supporting PHP 5.6+) we can't use the latest version of the library yet.
That's why this bugfix is target at the 4.x branch and I hope you consider merging it.
The bug that we're facing with v4 is that translator comments get added to multiple functions if they are all on the same line, instead of just to 1 function.
The tests should demonstrate this, but basically with PHP code like this:
The two translator comments should only be added to
__( 'World' )
and__( 'Within printf: %s' )
, respectively.