Fix Facebook API October 24th changes

[reflexxion]

As described in #392 facebook did change it's API for oembed and now requires a access_token for getting oembed data.
@oscarotero prepared Extractors for this case but the settings could only be set "too late".
48e3918

With this PR it's now possible to provide the settings to the ExtractorFactory.

                $embed = new Embed\Embed();
                $extractorFactory = new \Embed\ExtractorFactory(
                    [
                        'instagram:token' => '1234|5678',
                        'facebook:token' => '1234|5678',
                    ]
                );
                $embed->setExtractorFactory($extractorFactory);
                $embed->get($url);

solves #392

[oscarotero]

Thanks for this pull request. This have a lot of changes, some related with code style and not with Facebook/Instagram issue. I'm not sure about all changes, so I'm going to leave comments.

[BSimon47]

I guess I am missing something!

While this thread indicates that the Facebook issue is "Fixed", when I run composer update embed/embed I do not see any update. All that shows up is a patch referencing Vimeo which fails to install.

I expect to see a "configure" link under the url_embed module in the "Extend" list on my Drupal Admin page in which to enter my Facebook credentials. But none exists. OR is there some other means to enter this information?

[oscarotero]

@BSimon47 Drupal module uses Embed 3.x and this PR is for Embed 4.x
The requirement of a api key for facebook was fixed in Embed v3.4.9.
The instructions to configure Embed in v3 are here: https://github.com/oscarotero/Embed/tree/v3.x#example-with-all-options
If you are using the Drupal module, I don't know how to configure it, but I guess there're a way to set an array of options.

[BSimon47]

Oscar, Happy 2021! First off, I trust you received my modest contribution via Paypal and please enjoy the “beer” 😊 Secondly, while I have 20+ years working with websites, building database driven content for much of it, I am relatively new to CMS having built two or three Drupal sites over the last few years. Thus I am not yet in a position to understand or tear apart someone else’s modules etc. I feel that your Embed Library et al. is a major breakthrough for Social Media Developers and while Open Social (A Drupal social Media Distribution) has finally opened the door for a 21 year old website I have been looking to rebuild for many years, it is the ability to easily embed content for sharing that will allow me to lure new users into my new version which has a targeted Demographic of Motion Picture and Television Industry Professionals who are versed only in the platforms of Facebook and Twitter etc.. Without this feature which has worked until just recently, I have little hope of growing my audience, but since the Drupal module(s) that are dependent upon embed/embed no longer render cards from Facebook and Twitter but just throw an error and the url, I am at a loss. That said, I have messaged and emailed EACH AND EVERY ONE of the developers behind the Drupal url_embed module ( https://www.drupal.org/project/url_embed ) that directly accesses your library asking them to please update, but none have responded. With (well healed) Supporting organizations: Lullabot, Acquia, and MD Systems, it surprises me that the module shows: Project information Seeking co-maintainer(s) Maintainers are looking for help reviewing issues. * Module categories: <https://www.drupal.org/project/project_module?f%5B2%5D=im_vid_3%3A57> Content, <https://www.drupal.org/project/project_module?f%5B2%5D=im_vid_3%3A63> Filters/Editors, <https://www.drupal.org/project/project_module?f%5B2%5D=im_vid_3%3A67> Media, <https://www.drupal.org/project/project_module?f%5B2%5D=im_vid_3%3A52> Third-party Integration * Ecosystem: <https://www.drupal.org/project/embed> Embed And with 2,538 sites report using this module Unfortunately, I am not qualified to jump in, or I would. I see no current provision in a configuration file or elsewhere to add the Facebook, Instagram or Twitter credentials anywhere within these embed related modules! So, I am wondering if you have any sort of pipeline that might inspire these folks to move on this to restore our ability to use these modules for embedding these two critical major players in the social Media sphere! Is there any way you can reach out to them with an offer of help to get this corrected? I am happy to send you files etc. from my distributions if that will help! Regards, Bruce A. Simon Ph: 818.414.1795 Email: <mailto:[email protected]> [email protected] From: Oscar Otero <[email protected]> Sent: Monday, January 4, 2021 10:17 AM To: oscarotero/Embed <[email protected]> Cc: Bruce Simon <[email protected]>; Mention <[email protected]> Subject: Re: [oscarotero/Embed] Fix Facebook API October 24th changes (#399) @BSimon47 <https://github.com/BSimon47> Drupal module uses Embed 3.x and this PR is for Embed 4.x The requirement of a api key for facebook was fixed in Embed v3.4.9. The instructions to configure Embed in v3 are here: https://github.com/oscarotero/Embed/tree/v3.x#example-with-all-options If you are using the Drupal module, I don't know how to configure it, but I guess there're a way to set an array of options. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#399 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGL43P3CYMHTM35ZR4WKWQLSYIA3TANCNFSM4TDQLGWA> . <https://github.com/notifications/beacon/AGL43P2MRLW7JY2V65R55XTSYIA3TA5CNFSM4TDQLGWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFTZSQHI.gif>

[oscarotero]

Hi, @BSimon47

Happy 2021 and yes, I received your "beers" Thank you very much!

Unfortunally, I don't have any expertise in Drupal and never was involved in Drupal development. I just created this library for a specific project and eventually it stated gaining popularity and Drupal is now using it for that plugin.

Looking at the plugin repo: https://git.drupalcode.org/project/url_embed, looks like there isn't much activity so if your project depends heavily on it, I'd recommend to fork and update it by yourself. It seems like there's, indeed, a way to configure it (I'm seeing the code), so I guess you can set somewhere the api token needed for Facebook.

Sorry, but I can't help you.

[BSimon47]

Oscar, What does this mean? I do not know how to do that! “fork and update it by yourself” Are you saying I’d add the code from https://github.com/oscarotero/Embed/tree/v3.x#example-with-all-options into that php page? Like I said, I do not understand how git works and where I’d even go from there, or are you saying I’d add it to my local files? How about I contact that guy https://git.drupalcode.org/davereid (Dave Reid) via Drupal and see if He might add your new code(s) and update the module? And then go down the line of the other contributors! This is way over my head! Bruce A. Simon Ph: 818.414.1795 Email: <mailto:[email protected]> [email protected] From: Oscar Otero <[email protected]> Sent: Tuesday, January 5, 2021 11:38 AM To: oscarotero/Embed <[email protected]> Cc: Bruce Simon <[email protected]>; Mention <[email protected]> Subject: Re: [oscarotero/Embed] Fix Facebook API October 24th changes (#399) Hi, @BSimon47 <https://github.com/BSimon47> Happy 2021 and yes, I received your "beers" Thank you very much! Unfortunally, I don't have any expertise in Drupal and never was involved in Drupal development. I just created this library for a specific project and eventually it stated gaining popularity and Drupal is now using it for that plugin. Looking at the plugin repo: https://git.drupalcode.org/project/url_embed, looks like there isn't much activity <https://git.drupalcode.org/project/url_embed/activity> so if your project depends heavily on it, I'd recommend to fork and update it by yourself. It seems like there's, indeed, a way to configure it (I'm seeing the code <https://git.drupalcode.org/project/url_embed/-/blob/8.x-1.x/src/UrlEmbed.php#L46> ), so I guess you can set somewhere the api token needed for Facebook. Sorry, but I can't help you. — You are receiving this because you were mentioned. Reply to this email directly, <#399 (comment)> view it on GitHub, or <https://github.com/notifications/unsubscribe-auth/AGL43PY5URYEVUM53DM7MD3SYNS7ZANCNFSM4TDQLGWA> unsubscribe. <https://github.com/notifications/beacon/AGL43PZCX3QRTTDA7L4LLDDSYNS7ZA5CNFSM4TDQLGWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFT7CNCA.gif>

[oscarotero]

@BSimon47 I mean fork (create a copy) the drupal module, not this repository.
Anyway, I guess you need help (or hire someone) that know Drupal. Your problem is not this library (Embed), but the drupal module (url_embed) that uses this library and I cannot help you with that.
Try to contact with Dave Reid, as you said.