Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conformance tests for VarietyFunctionField, add base_ring_type method #4417

Merged
merged 6 commits into from
Jan 9, 2025

Apply suggestions from code review

4ce9a46
Select commit
Loading
Failed to load commit list.
Merged

Add conformance tests for VarietyFunctionField, add base_ring_type method #4417

Apply suggestions from code review
4ce9a46
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 9, 2025 in 0s

84.37% (-0.02%) compared to d1d6926

View this Pull Request on Codecov

84.37% (-0.02%) compared to d1d6926

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.37%. Comparing base (d1d6926) to head (4ce9a46).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4417      +/-   ##
==========================================
- Coverage   84.39%   84.37%   -0.02%     
==========================================
  Files         659      663       +4     
  Lines       87183    87808     +625     
==========================================
+ Hits        73575    74088     +513     
- Misses      13608    13720     +112     
Files with missing lines Coverage Δ
...icGeometry/Schemes/FunctionField/FunctionFields.jl 81.17% <100.00%> (+4.58%) ⬆️

... and 21 files with indirect coverage changes