Move LieTheory serialization to src; add WeightLattice serialization
#4414
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4414 +/- ##
==========================================
- Coverage 84.38% 84.38% -0.01%
==========================================
Files 658 658
Lines 87157 87133 -24
==========================================
- Hits 73551 73530 -21
+ Misses 13606 13603 -3
|
|
|
||
| function save_object(s::SerializerState, P::WeightLattice) | ||
| save_data_dict(s) do | ||
| save_typed_object(s, root_system(P), :root_system) |
There was a problem hiding this comment.
the type information for the root system will be moved out during the upcoming refactor,
If you can rewrite this so that Weight Lattice uses params, this will make the upgrade simple / virtually nothing (as in the file wont change just the code)
| end | ||
| end | ||
|
|
||
| function load_object(s::DeserializerState, ::Type{WeightLattice}) |
There was a problem hiding this comment.
this would then need to accept root system as the third parameter
| end | ||
|
|
||
| function load_object(s::DeserializerState, ::Type{WeylGroup}) | ||
| R = load_typed_object(s, :root_system) |
There was a problem hiding this comment.
similarly here, however since we could already save this, I think it's best to leave this to the refactor.
|
Since |
|
Probably won't make too much of a difference, so I'll just merge |
antonydellavecchia
merged commit 3dd332d
into
oscar-system:master
|
Thanks :) |
This part was not moved as part of #4399.