Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support character_field for a vector of characters #4411

Merged

Conversation

ThomasBreuer
Copy link
Member

@ThomasBreuer ThomasBreuer commented Dec 20, 2024

This feature turned out to be useful in the computations with S-characters.

@ThomasBreuer ThomasBreuer added enhancement New feature or request topic: groups labels Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.38%. Comparing base (57c1b68) to head (8392dcd).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4411      +/-   ##
==========================================
- Coverage   84.38%   84.38%   -0.01%     
==========================================
  Files         658      658              
  Lines       87162    87173      +11     
==========================================
+ Hits        73555    73564       +9     
- Misses      13607    13609       +2     
Files with missing lines Coverage Δ
src/GAP/wrappers.jl 95.16% <100.00%> (+0.01%) ⬆️
src/Groups/group_characters.jl 95.73% <100.00%> (+0.08%) ⬆️

... and 7 files with indirect coverage changes

@ThomasBreuer ThomasBreuer requested a review from fingolfin January 2, 2025 09:44
@fingolfin fingolfin merged commit ca6a3c3 into oscar-system:master Jan 6, 2025
29 of 30 checks passed
@ThomasBreuer ThomasBreuer deleted the TB_common_character_field branch January 6, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request topic: groups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants