Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump AA, Nemo, Hecke #4405

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Bump AA, Nemo, Hecke #4405

merged 2 commits into from
Dec 16, 2024

Conversation

lgoettgens
Copy link
Member

cc @thofma @fingolfin

Still waiting for thofma/Hecke.jl#1704

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.37%. Comparing base (01f31ee) to head (e1b9d0b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4405      +/-   ##
==========================================
- Coverage   84.40%   84.37%   -0.03%     
==========================================
  Files         656      656              
  Lines       87270    87270              
==========================================
- Hits        73662    73637      -25     
- Misses      13608    13633      +25     

see 3 files with indirect coverage changes

@lgoettgens lgoettgens marked this pull request as ready for review December 16, 2024 13:57
@lgoettgens
Copy link
Member Author

The one CI failure is #4402. IMO this is good to go.

@thofma thofma merged commit 9130d06 into oscar-system:master Dec 16, 2024
29 of 30 checks passed
@thofma
Copy link
Collaborator

thofma commented Dec 16, 2024

Thanks

@lgoettgens lgoettgens deleted the lg/bump-deps branch December 16, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants