Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check argument for map of polynomial rings #4398

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix: check argument for map of polynomial rings #4398

merged 1 commit into from
Dec 12, 2024

Conversation

thofma
Copy link
Collaborator

@thofma thofma commented Dec 11, 2024

wdecker
wdecker approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@wdecker wdecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thofma thx!

With regard to the tests: I suggest to first merge PR #4395 and then restart the tests here.

@thofma thofma closed this Dec 12, 2024
@thofma thofma reopened this Dec 12, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.45%. Comparing base (23b0b9d) to head (2c1d8a8).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4398      +/-   ##
==========================================
+ Coverage   84.40%   84.45%   +0.05%     
==========================================
  Files         656      656              
  Lines       87216    87857     +641     
==========================================
+ Hits        73612    74204     +592     
- Misses      13604    13653      +49
Files with missing lines Coverage Δ
src/Rings/MPolyMap/MPolyQuo.jl 90.62% <100.00%> (+0.14%) ⬆️

... and 3 files with indirect coverage changes

@wdecker wdecker merged commit 9a4a751 into master Dec 12, 2024
51 of 59 checks passed
@wdecker wdecker deleted the th/check branch December 12, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wdecker wdecker wdecker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thofma @wdecker