Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format @article entries consistently #4115

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Format @article entries consistently #4115

merged 2 commits into from
Sep 20, 2024

Conversation

lgoettgens
Copy link
Member

@lgoettgens lgoettgens commented Sep 19, 2024

Resolves #3760.

This needs to wait for a merge and release of JuliaDocs/DocumenterCitations.jl#74 before merge.

Furthermore, we need to change how arxiv-only references are stored in the bibliography.

Preview: https://docs.oscar-system.org/previews/PR4115/references/

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.66%. Comparing base (16ee5ef) to head (f0c491b).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4115      +/-   ##
==========================================
- Coverage   84.67%   84.66%   -0.02%     
==========================================
  Files         626      626              
  Lines       83982    84217     +235     
==========================================
+ Hits        71110    71299     +189     
- Misses      12872    12918      +46     

see 24 files with indirect coverage changes

@lgoettgens lgoettgens force-pushed the lg/citations-href branch 2 times, most recently from 08846f5 to f0c491b Compare September 19, 2024 13:17
@lgoettgens lgoettgens marked this pull request as ready for review September 19, 2024 13:22
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fingolfin fingolfin merged commit 6538b3a into master Sep 20, 2024
29 checks passed
@fingolfin fingolfin deleted the lg/citations-href branch September 20, 2024 09:38
HechtiDerLachs pushed a commit to HechtiDerLachs/Oscar.jl that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bibliography link anchors inconsistent
2 participants