-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Grassmann Pluecker #3382
Fix Grassmann Pluecker #3382
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3382 +/- ##
==========================================
- Coverage 82.08% 82.06% -0.03%
==========================================
Files 556 557 +1
Lines 74072 73973 -99
==========================================
- Hits 60805 60704 -101
- Misses 13267 13269 +2
|
I think it would be unfortunate to call the function |
Ya that would be ideal. |
OK, this was easier than expected. I also took the liberty to clean up one of the conversions. |
Co-authored-by: Benjamin Lorenz <[email protected]>
* fixed * fix for symmetric intersections test * back to the roots * revert * Apply suggestions from code review Co-authored-by: Benjamin Lorenz <[email protected]> --------- Co-authored-by: Tommy Hofmann <[email protected]> Co-authored-by: Benjamin Lorenz <[email protected]> (cherry picked from commit 7433548)
### Backported PRs - [x] #3367 - [x] #3379 - [x] #3369 - [x] #3291 - [x] #3325 - [x] #3350 - [x] #3351 - [x] #3365 - [x] #3366 - [x] #3382 - [x] #3373 - [x] #3341 - [x] #3346 - [x] #3381 - [x] #3385 - [x] #3387 - [x] #3398 - [x] #3399 - [x] #3374 - [x] #3406 - [x] #2823 - [x] #3298 - [x] #3386 - [x] #3412 - [x] #3392 - [x] #3415 - [x] #3394 - [x] #3391
grassmann_pluecker_ideal returns ideal with knowledge of the the computed groebner basis
related to #3374