Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyhedral: add hash method for Cone + Polyhedron #2955

Merged
merged 7 commits into from
Oct 27, 2023
Merged

Conversation

benlorenz
Copy link
Member

These have a custom == function, so they need a hash function (#2222).
We cannot reasonably hash the polytopes as we want to avoid triggering a convex hull computation. And even if we did, that would not give us a normal form that we could use for the hash. So we just hash the type and the ambient dimension.

Also add ambient_dim for LP and MILP.

x-ref: #2832

@benlorenz benlorenz requested a review from lkastner October 25, 2023 11:39
@benlorenz benlorenz mentioned this pull request Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #2955 (4658ece) into master (4918a7a) will increase coverage by 0.00%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           master    #2955    +/-   ##
========================================
  Coverage   80.34%   80.35%            
========================================
  Files         469      470     +1     
  Lines       66416    66659   +243     
========================================
+ Hits        53365    53566   +201     
- Misses      13051    13093    +42     
Files Coverage Δ
src/PolyhedralGeometry/Cone/constructors.jl 89.13% <100.00%> (+1.03%) ⬆️
src/PolyhedralGeometry/Polyhedron/constructors.jl 93.61% <100.00%> (+0.59%) ⬆️
src/PolyhedralGeometry/linear_program.jl 92.72% <100.00%> (+0.13%) ⬆️
...PolyhedralGeometry/mixed_integer_linear_program.jl 57.14% <100.00%> (+0.69%) ⬆️

... and 14 files with indirect coverage changes

@benlorenz benlorenz merged commit 821055d into master Oct 27, 2023
10 of 16 checks passed
@benlorenz benlorenz deleted the bl/polyhash branch October 27, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants