Relax signature of ==(::MPolyIdeal, ::MPolyIdeal)
#2937
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change, but requires a long explanation:
The current signature of
==
for ideals in multivariate polynomial rings isso this function is not called if one tries to compare ideals in polynomial rings of different type (
T
), instead the generic==
is called:The answer
false
is of course not wrong, but in my opinion this should error because the comparison doesn't make sense; this is what I added in this PR: