fix for serializing 0 ideal #2871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2871 +/- ##
=======================================
Coverage 80.58% 80.58%
=======================================
Files 456 456
Lines 64992 64992
=======================================
+ Hits 52371 52372 +1
+ Misses 12621 12620 -1
|
HechtiDerLachs
approved these changes
Sep 29, 2023
| @@ -259,7 +259,7 @@ const IdealUnionType = Union{MPolyIdeal, LaurentMPolyIdeal, FreeAssAlgIdeal} | |||
| function save_type_params(s::SerializerState, x::T) where T <: IdealUnionType | |||
| save_data_dict(s) do | |||
| save_object(s, encode_type(T), :name) | |||
| ref = save_as_ref(s, parent(gens(x)[1])) | |||
| ref = save_as_ref(s, base_ring(x)) | |||
There was a problem hiding this comment.
Yes, that's exactly what I was thinking. Sorry, I should have spelled out that fix straight away. At some point it was also suggested to support ring(I::Ideal) rather than base_ring(I::Ideal), but that does not seem to have gone through, yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't realise base_ring was the function i was looking for