Space Germs and Milnor Algebra/Number

[afkafkafk13]

No description provided.

[codecov]

Codecov Report

Merging #2860 (469a5e6) into master (227f63f) will decrease coverage by 0.15%.
Report is 15 commits behind head on master.
The diff coverage is 63.38%.

@@            Coverage Diff             @@
##           master    #2860      +/-   ##
==========================================
- Coverage   80.67%   80.53%   -0.15%     
==========================================
  Files         456      456              
  Lines       64805    65208     +403     
==========================================
+ Hits        52282    52514     +232     
- Misses      12523    12694     +171     

Files	Coverage Δ
src/Rings/mpoly-localizations.jl	76.53% <100.00%> (+0.18%)	⬆️
src/Rings/mpolyquo-localizations.jl	73.58% <100.00%> (+0.54%)	⬆️
experimental/Schemes/SpaceGerms.jl	68.43% <63.09%> (-14.90%)	⬇️

... and 25 files with indirect coverage changes

[afkafkafk13]

Remark: code-coverage goes down due to functionality which is prepared for upcoming extensions of the localization framework -- obviously, testing this is not feasable before the extension.

[HechtiDerLachs]

Thanks for putting this up again. I left some comments.

[afkafkafk13]

@HechtiDerLachs : Thank you very much for careful reading and all the suggestions. I tried to incorporate everything.

[fingolfin]

Thank you. I left a bunch of nitpick comments, only regarding style things. Don't be alarmed by the seemingly large number, they are small, and if you like, you can just go through them in the web browser and apply them by clicking

[afkafkafk13]

@fingolfin : Thank you for the beautifying of my code. That helps a lot for the future.