Computeralgebra Rundbrief #2854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afkafkafk13
reviewed
Sep 26, 2023
src/AlgebraicGeometry/Schemes/CoveredSchemes/Morphisms/Methods.jl
Outdated
Show resolved
Hide resolved
src/AlgebraicGeometry/Schemes/ProjectiveSchemes/Morphisms/Attributes.jl
Outdated
Show resolved
Hide resolved
src/AlgebraicGeometry/Schemes/ProjectiveSchemes/Morphisms/Constructors.jl
Outdated
Show resolved
Hide resolved
ambient_embedding for projective schemes.
Co-authored-by: Simon Brandhorst <[email protected]>
|
Ready for merge. All required tests have passed for commit 64150f4. Let's save some energy here. |
simonbrandhorst
approved these changes
Sep 28, 2023
afkafkafk13
approved these changes
Sep 28, 2023
fieker
pushed a commit
that referenced
this pull request
Sep 29, 2023
* Implement unions and intersections of projective schemes, closed embeddings for projective schemes. conversion of projective closed embeddings to covered closed embeddings, composition of closed embeddings. * Partially implement fiber products of closed embeddings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some preparations for our article.
CC: @afkafkafk13 , @simonbrandhorst